Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Better icons? #104

Closed
moshmage opened this issue May 16, 2014 · 6 comments
Closed

[UI] Better icons? #104

moshmage opened this issue May 16, 2014 · 6 comments
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.

Comments

@moshmage
Copy link

I was going to write a userscript to overhaul the css of the website, but I thought that to be overkill and instead started to change the icons of the top-bar first.
After choosing them icons, I proceeded to replace them via-firebug and just as I was about to start writing code... It hit me: Why not suggest it? :)
http://imgur.com/DrYugFe <- this is the website with them fabulous gnome icons (grabbed from a free-stock icons website)
Follows the links for the icons:
http://imgur.com/aVkM56V <- scripts
http://imgur.com/Jf59NBY <- toolboxs
http://imgur.com/CcgWDtw <- groups
http://imgur.com/tOn5BzA <- beggars
http://imgur.com/m0ZBeJp <- the garage

Some day soon I'll try and actually contribute to the projects css, today I'm toooooo lazy (besides. It's friday and I need to get out of work in 15m so I can play RUST like I am in house-arrest xD)

@moshmage
Copy link
Author

by the way, this is where I took the icons from http://www.iconspedia.com/search/gnome/all/all/54/120.html

@moshmage moshmage mentioned this issue May 16, 2014
32 tasks
@Martii
Copy link
Member

Martii commented May 16, 2014

Desktops are just as important but we also need screenshots from minimum cell phone resolution and maximum too. OUJS looks fabulous on every cell I've looked at it on (related to #12)... as compared to some other sites. Gnomes project should be GPL so I don't see any issue with licensing other than a brief attribution.... however iconspedia.com doesn't appear to be the official upstream repo for this. Also blocked external fonts is a consideration for display purposes. See #86

http://imgur.com/tOn5BzA <- beggars

LOL! "HELP! HELP! I don't know how to swim!" ;)

We'll see what @DoctorSnowman is coming up with... I believe he is part of the front end team. Thanks for the screencaps. :)

As an editorial note it's not totally necessary to indicate in the issue name what category it falls under... one of us will label it appropriately (look up and to your right under labels)... so that being said I renamed the [NOT ISSUE] to [UI] because everything can be considered an issue when you post it here.

@Martii Martii added UI labels May 16, 2014
@Martii Martii changed the title [NOT ISSUE] Better icons? Better icons? May 16, 2014
@Martii Martii changed the title Better icons? UI: Better icons? May 16, 2014
@Martii Martii changed the title UI: Better icons? [UI] Better icons? May 16, 2014
@moshmage
Copy link
Author

True. I'll try and follow #103's OP example and throw a little shindig so I can also test it on mobile (... or I could have just resized the window, but that's bananas). Other thing is, with a few media queries in place you could use the full power of the screen.

We shall see what @DoctorSnowman has up his sleeve; worst case scenario, users will userscript your userscript site. They all heard you like userscripts badum-ts

LOL I couldn't pin-point the Icon and I was like "hm.. whoever comes here wants a floater to be with the cool kids" x)

Also, I added "not issue" as to not sound like a little b. because at the end of writing it all I felt like one.

@Martii
Copy link
Member

Martii commented May 16, 2014

(... or I could have just resized the window, but that's bananas)

I wish it was that easy but actual mobile shot(s) is preferred. Emulators don't always show the true rendering.

worst case scenario, users will userscript your userscript site.

It's "our" site and there is nothing wrong with adding extra functionality in. USO is very much designed in this fashion. Some items of course should be in the backend but allows everyone to have their own opinion on how they like to manage the UI.

I added "not issue" as to not sound like

It's alright. I'm just letting you know how GH works with labeling and tracking issues. I do RFE: in front of a Request For Enhancement but it really isn't necessary. The subject should be as succinct as possible though and doing too much of a label in the subject makes for more "noise" as the term goes.

@Martii Martii reopened this May 16, 2014
@sizzlemctwizzle
Copy link
Member

@moshmage

Follows the links for the icons:

First off, thanks for the suggestion and finding these icons. But I personally think those icons look boring and generic. Definitely the life-preserver isn't in theme with the "Beggar's Corner". I'd rather just shrink down the icons we already have.

I'm going to reject this suggestion for now, because I like the current icons better, but go ahead and create the script if you like. I'll try it out myself and maybe you'll win me over (or more likely others who will convince me that I'm wrong).

Closing, but if anyone on the team wants to discuss this further, just reopen and mention me.

@moshmage
Copy link
Author

@sizzlemctwizzle I have to agree that the beggars help is a "little" out of his scope, and with the icons being generic. But I might do the script indeed or I might not even need it, who knows :)
Maybe shrinking down is indeed enough.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Development

No branches or pull requests

3 participants