Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of revoke when revoke-expired is intended #1167

Closed
TinCanTech opened this issue Jun 12, 2024 · 0 comments · Fixed by #1174
Closed

Use of revoke when revoke-expired is intended #1167

TinCanTech opened this issue Jun 12, 2024 · 0 comments · Fixed by #1174

Comments

@TinCanTech
Copy link
Collaborator

TinCanTech commented Jun 12, 2024

Accidental use of revoke, when revoke-expired is intended, leads to revoking the wrong certificate.

This accidental use is caused as follows:

  • Generate or receive a request: gen-req alice
  • Sign the request: sign-req client alice
  • Sometime later - Certificate alice expires: expire alice
  • Sign a new certificate for alice: sign-req client alice
  • Sometime later (2) - Certificate alice expires: expire alice
  • Unable to use command expire alice due to old certificate for alice, which must be revoked by command revoke-expired.
  • Intending to revoke the expired certificate for alice; use of command revoke alice, instead of the intended revoke-expired alice, results in revoking the wrong certificate.

An annoying and insidious trap!

The solution appears to be: Prohibit Warn and get confirmation for use of revoke alice, while an expired certificate for alice is still present in the expired directory.

Possibly create command revoke-issued, to complement revoke-expired and revoke-renewed, and force use of revoke into choosing which type of certificate is intended to be revoked, when multiple types of files exist. This seems unnecessary.

Or, rename revoke-expired to remove-expired.

Or, store expired certificates by serial number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant