make private

Author: JarbasAl

mycroft/skills/mycroft_skill/mycroft_skill.py

@@ -398,8 +398,8 @@ def _register_system_event_handlers(self):
         # Only register stop if it's been implemented
         if self.stop_is_implemented:
             self.add_event('mycroft.stop', self.__handle_stop)
-        self.add_event('mycroft.skill.converse.ping', self.handle_converse_ack)
-        self.add_event('mycroft.skill.converse.request', self.handle_converse_request)
+        self.add_event('mycroft.skill.converse.ping', self._handle_converse_ack)
+        self.add_event('mycroft.skill.converse.request', self._handle_converse_request)
         self.add_event(f"{self.skill_id}.activate", self.handle_activate)
         self.add_event(f"{self.skill_id}.deactivate", self.handle_deactivate)
         self.add_event("intent.service.skills.deactivated", self._handle_skill_deactivated)
@@ -503,16 +503,17 @@ def deactivate(self):
         self.bus.emit(msg.forward(f"intent.service.skills.deactivate",
                                   data={"skill_id": self.skill_id}))
 
-    def handle_converse_ack(self, message):
+    def _handle_converse_ack(self, message):
+        """Inform skills service if we want to handle converse.
+        individual skills may override the property self.converse_is_implemented"""
         self.bus.emit(message.reply(
             "mycroft.skill.converse.pong",
             data={"skill_id": self.skill_id,
                   "can_handle": self.converse_is_implemented},
             context={"skill_id": self.skill_id}))
 
-    def handle_converse_request(self, message):
+    def _handle_converse_request(self, message):
         """Check if the targeted skill id can handle conversation
-
         If supported, the conversation is invoked.
         """
         skill_id = message.data['skill_id']