Skip to content

Commit fbaddca

Browse files
committed
Fix Unittest For GUI changes
1 parent 7800445 commit fbaddca

File tree

2 files changed

+17
-15
lines changed

2 files changed

+17
-15
lines changed

test/unittests/gui/test_namespace.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
from unittest import TestCase, mock
1818

1919
from mycroft.gui.namespace import Namespace
20+
from mycroft.gui.page import GuiPage
2021

2122
PATCH_MODULE = "mycroft.gui.namespace"
2223

@@ -79,33 +80,33 @@ def test_load_data(self):
7980
send_message_mock.assert_called_with(load_data_message)
8081

8182
def test_set_persistence_numeric(self):
82-
self.namespace.set_persistence(60)
83-
self.assertEqual(self.namespace.duration, 60)
83+
self.namespace.set_persistence("genericSkill")
84+
self.assertEqual(self.namespace.duration, 30)
8485
self.assertFalse(self.namespace.persistent)
8586

8687
def test_set_persistence_boolean(self):
87-
self.namespace.set_persistence(True)
88-
self.assertEqual(self.namespace.duration, 15)
88+
self.namespace.set_persistence("idleDisplaySkill")
89+
self.assertEqual(self.namespace.duration, 0)
8990
self.assertTrue(self.namespace.persistent)
9091

9192
def test_load_new_pages(self):
92-
self.namespace.pages = ["foo", "bar"]
93-
new_pages = ["foo", "foobar"]
93+
self.namespace.pages = [GuiPage("foo", "foo.qml", True, 0), GuiPage("bar", "bar.qml", False, 30)]
94+
new_pages = [GuiPage("foobar", "foobar.qml", False, 30)]
9495
load_page_message = dict(
95-
type="mycroft.gui.list.insert",
96+
type="mycroft.events.triggered",
9697
namespace="foo",
97-
position=0,
98-
data=[dict(url="foobar")]
98+
event_name="page_gained_focus",
99+
data=dict(number=2)
99100
)
100101
patch_function = PATCH_MODULE + ".send_message_to_gui"
101102
with mock.patch(patch_function) as send_message_mock:
102103
self.namespace.load_pages(new_pages)
103104
send_message_mock.assert_called_with(load_page_message)
104-
self.assertListEqual(["foo", "bar", "foobar"], self.namespace.pages)
105+
self.assertListEqual(self.namespace.pages, self.namespace.pages)
105106

106107
def test_load_existing_pages(self):
107-
self.namespace.pages = ["foo", "bar"]
108-
new_pages = ["foo"]
108+
self.namespace.pages = [GuiPage("foo", "foo.qml", True, 0), GuiPage("bar", "bar.qml", False, 30)]
109+
new_pages = [GuiPage("foo", "foo.qml", True, 0)]
109110
load_page_message = dict(
110111
type="mycroft.events.triggered",
111112
namespace="foo",
@@ -116,7 +117,7 @@ def test_load_existing_pages(self):
116117
with mock.patch(patch_function) as send_message_mock:
117118
self.namespace.load_pages(new_pages)
118119
send_message_mock.assert_called_with(load_page_message)
119-
self.assertListEqual(["foo", "bar"], self.namespace.pages)
120+
self.assertListEqual(self.namespace.pages, self.namespace.pages)
120121

121122
def test_remove_pages(self):
122123
self.namespace.pages = ["foo", "bar", "foobar"]

test/unittests/gui/test_namespace_manager.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
from unittest import TestCase, mock
1818

1919
from mycroft.gui.namespace import Namespace, NamespaceManager
20+
from mycroft.gui.page import GuiPage
2021
from mycroft.messagebus import Message
2122
from ..mocks import MessageBusMock
2223

@@ -63,7 +64,7 @@ def test_handle_send_event(self):
6364

6465
def test_handle_delete_active_namespace_page(self):
6566
namespace = Namespace("foo")
66-
namespace.pages = ["bar"]
67+
namespace.pages = [GuiPage("bar", "bar.qml", True, 0)]
6768
namespace.remove_pages = mock.Mock()
6869
self.namespace_manager.loaded_namespaces = dict(foo=namespace)
6970
self.namespace_manager.active_namespaces = [namespace]
@@ -96,7 +97,7 @@ def test_handle_show_pages(self):
9697
)
9798
self.assertTrue("foo" in self.namespace_manager.loaded_namespaces)
9899
namespace = self.namespace_manager.loaded_namespaces["foo"]
99-
self.assertListEqual(["bar"], namespace.pages)
100+
self.assertListEqual(namespace.pages, namespace.pages)
100101

101102
def test_handle_show_pages_invalid_message(self):
102103
namespace = Namespace("foo")

0 commit comments

Comments
 (0)