Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mute should be broken with setting a volume #26

Closed
emphasize opened this issue Sep 27, 2023 · 2 comments
Closed

mute should be broken with setting a volume #26

emphasize opened this issue Sep 27, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@emphasize
Copy link
Member

emphasize commented Sep 27, 2023 •
edited
Loading

ATM you have to unmute the state to get back to normal. One step too much imho.
@JarbasAl
Copy link
Member

agreed!

@JarbasAl JarbasAl added the bug Something isn't working label Sep 27, 2023
@emphasize
Copy link
Member Author

emphasize commented Sep 27, 2023 •
edited
Loading

but actually this should be done in the PHAL plugins.
(and i'm in favour that the listener/audio is checking if state is muted and in case of confirm_listening unmute for the time being)

@emphasize emphasize mentioned this issue Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emphasize @JarbasAl