fix/none_type

[JarbasAl]

closes #26

[mikejgray]

Why not make the default an empty dict instead of None and then change it later?

[JarbasAl]

Why not make the default an empty dict instead of None and then change it later?

setting a empty dict or list in the method definition is a common mistake in python

Default values in Python are created exactly once, when the function is defined. If that object is changed, subsequent calls to the function will refer to the changed object, ie, context would be kept around across calls

eg

def b(x=[]):
    x.append(5)
    print(x)

>>> b()
[5]
>>> b()
[5, 5]

[mikejgray]

Python really needs an immutable dict and list type... :P

[mikejgray]

Tests are failing

[JarbasAl]

Tests are failing

they have been for a while :P unrelated to this PR

we really need to do some cleanup around all skill repos, many have copy pasted automations just to get them published but then have failing tests that just came from somewhere else