fix: add skill.json, resolve failing tests #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test was introduced here. Working on getting it right again - not sure the translation is working properly. |
|
Test passes locally on 3.10, but it looks like something in 3.7 is not happy with it... |
JarbasAl
approved these changes
Oct 9, 2023
❯ pytest
=================================================================== test session starts ====================================================================
platform darwin -- Python 3.7.17, pytest-7.4.2, pluggy-1.2.0
rootdir: /Users/Mike/Documents/coding/VoiceAssistants/skill-icanhazdadjokes
plugins: cov-4.1.0
collected 8 items
tests/test_joking.py ........ [100%]
===================================================================== warnings summary =====================================================================
.venv/lib/python3.7/site-packages/pyee/__init__.py:41
tests/test_joking.py::TestSkill::test_chuck_norris_joke
/Users/Mike/Documents/coding/VoiceAssistants/skill-icanhazdadjokes/.venv/lib/python3.7/site-packages/pyee/__init__.py:41: DeprecationWarning: pyee.BaseEventEmitter is deprecated and will be removed in a future major version; you should instead use pyee.EventEmitter.
"pyee.BaseEventEmitter is deprecated and will be removed in a "
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================================================== 8 passed, 2 warnings in 1.94s =============================================================== |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
mikejgray
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.