Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and some additions #15

Merged
merged 6 commits into from
Jan 18, 2023
Merged

Refactor and some additions #15

merged 6 commits into from
Jan 18, 2023

Conversation

emphasize
Copy link
Member

@emphasize emphasize commented Oct 27, 2022 •
edited
Loading

fixes:

  • accidentally translated mustached variables in dialogs
  • message type when fetching the system volume volume.get -> mycroft.volume.get

refactor:

  • dialog naming
  • adapt intents

additions:

  • error dialog (if system volume couldn't be fetched)
  • possibility to incrementally increase/decrease volume by 10% when asking for a relative change (omitting "by x percent", i.e. "increase volume" or simply "louder")
  • get_response when asking for a total change and not mentioning the value (with validator)

tested (german)

@emphasize
Copy link
Member Author

emphasize commented Oct 27, 2022 •
edited
Loading

Will add additional translations (to the existing vocs) in a while --done

@emphasize
Copy link
Member Author

emphasize commented Oct 27, 2022 •
edited
Loading

Just realized nl-nl is missing --done

@JarbasAl JarbasAl merged commit a191fdb into OpenVoiceOS:dev Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emphasize @JarbasAl