Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transient dependencies #1247

Closed
ericnordelo opened this issue Dec 3, 2024 · 0 comments · Fixed by #1249
Closed

Fix transient dependencies #1247

ericnordelo opened this issue Dec 3, 2024 · 0 comments · Fixed by #1249
Assignees
Milestone

Comments

@ericnordelo
Copy link
Member

🧐 Motivation
In Scarb 2.9.x transient deps no longer work. For example, this used to work when depending on openzeppelin:

#[starknet::contract]
mod HelloStarknet {
    use openzeppelin_utils::cryptography::snip12;
    #[storage]
    struct Storage {
        balance: felt252, 
    }
}

but does not build with 2.9.1 as openzeppelin_utils is not an explicit dependency.

In a few places like here, we use dev dependencies in non-testing code.

This messes up creating a package with 2.9.1. Unfortunately, it still builds with 2.9.1.

Transient dependencies should be then removed/fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Resolved
Development

Successfully merging a pull request may close this issue.

2 participants