Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in initializer function of ownable contract #645

Closed
irisdv opened this issue Jul 5, 2023 · 0 comments · Fixed by #660
Closed

Inconsistency in initializer function of ownable contract #645

irisdv opened this issue Jul 5, 2023 · 0 comments · Fixed by #660
Assignees
@ericnordelo

Comments

@irisdv
Copy link

irisdv commented Jul 5, 2023

The initializer function of ownable used to accept an argument owner: felt:
https://github.com/OpenZeppelin/cairo-contracts/blob/main/src/openzeppelin/access/ownable/library.cairo#L31

The new version on the cairo-1 branch does not have this argument :
https://github.com/OpenZeppelin/cairo-contracts/blob/cairo-1/src/openzeppelin/access/ownable/ownable.cairo#L74
@ericnordelo ericnordelo mentioned this issue Jul 13, 2023
Merged
@ericnordelo ericnordelo added this to the current milestone Jul 13, 2023
@ericnordelo ericnordelo linked a pull request Jul 13, 2023 that will close this issue
Add owner param to ownable initializer #660
Merged
@ericnordelo ericnordelo self-assigned this Jul 13, 2023
@ericnordelo ericnordelo moved this to 👀 In review in Contracts for Cairo Jul 13, 2023
@ericnordelo ericnordelo moved this from 👀 In review to ✅ Resolved in Contracts for Cairo Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericnordelo ericnordelo

Labels
None yet
Projects
Contracts for Cairo
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add owner param to ownable initializer ericnordelo/cairo-contracts
2 participants
@irisdv @ericnordelo