Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Overview code sample #805

Closed
martriay opened this issue Oct 31, 2023 · 0 comments · Fixed by #819
Closed

Update Overview code sample #805

martriay opened this issue Oct 31, 2023 · 0 comments · Fixed by #819
Assignees
@ericnordelo
Labels
documentation Improvements or additions to documentation

Comments

@martriay
Copy link
Contributor

martriay commented Oct 31, 2023 •
edited
Loading

Currently the code sample shown in the docsite's landing is an Account contract, which is not the fanciest one. It's a rather complex component since it requires embedding several impls and it depends on another component (SRC5).

I propose changing it for an ERC20 token contract code sample which is easier and arguably more useful/demanded than an Account one.
@martriay martriay added the documentation Improvements or additions to documentation label Oct 31, 2023
This was referenced Oct 31, 2023
Merged
Closed
@martriay martriay moved this to 📋 Backlog in Contracts for Cairo Nov 5, 2023
@martriay martriay added this to the next milestone Nov 5, 2023
@ericnordelo ericnordelo self-assigned this Nov 8, 2023
@ericnordelo ericnordelo mentioned this issue Nov 10, 2023
Merged
3 tasks
@ericnordelo ericnordelo moved this from 📋 Backlog to 👀 In review in Contracts for Cairo Nov 10, 2023
@ericnordelo ericnordelo removed this from the 1. current milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericnordelo ericnordelo

Labels
documentation Improvements or additions to documentation
Projects
Contracts for Cairo
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update overview code sample ericnordelo/cairo-contracts
2 participants
@martriay @ericnordelo