Improve customError testing

Author: Amxx

test/helpers/customError.js

@@ -2,9 +2,10 @@ const { expect } = require('chai');
 
 /** Revert handler that supports custom errors. */
 async function expectRevertCustomError(promise, expectedErrorName, args) {
+  let promiseSuccesseded = false;
   try {
     await promise;
-    expect.fail("Expected promise to throw but it didn't");
+    promiseSuccesseded = true;
   } catch (revert) {
     if (!Array.isArray(args)) {
       expect.fail('Expected 3rd array parameter for error arguments');
@@ -38,6 +39,9 @@ async function expectRevertCustomError(promise, expectedErrorName, args) {
     // Assert argument equality
     expect(sanitizedActual).to.have.members(sanitizedExpected, `Unexpected ${errorName} arguments`);
   }
+  if (promiseSuccesseded) {
+    expect.fail("Expected promise to throw but it didn't");
+  }
 }
 
 module.exports = {