Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider switching Address.isContract back to extcodesize #2310

Closed
frangio opened this issue Jul 13, 2020 · 1 comment · Fixed by #2311
Closed

Consider switching Address.isContract back to extcodesize #2310

frangio opened this issue Jul 13, 2020 · 1 comment · Fixed by #2311

Comments

@frangio
Copy link
Contributor

frangio commented Jul 13, 2020

See #1802 (comment) by @juli for more details.
@julianmrodri julianmrodri mentioned this issue Jul 13, 2020
Merged
@julianmrodri
Copy link
Contributor

Submitted a PR and some values for gas consumption so we can analyze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use extcodesize for isContract to reduce gas julianmrodri/openzeppelin-contracts
2 participants
@frangio @julianmrodri