Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ERC1155 uri format cannot be customized or invoked within contracts that inherit from ERC1155 #2652

Closed
ookvic opened this issue Apr 30, 2021 · 1 comment

Comments

@ookvic
Copy link

ookvic commented Apr 30, 2021

The ERC1155 uri format cannot be customized or invoked within contracts that inherit from ERC1155

function uri(uint256) external view virtual override returns (string memory) { return _uri; }
uri methods cannot be called internally ,
It is recommended to use public modifiers, The following code:
function uri(uint256) public view virtual override returns (string memory) { return _uri; }

@Amxx
Copy link
Collaborator

Amxx commented May 3, 2021

Hello,
This issue was addressed in #2576 and is part of the ^4.0 releases.

@frangio frangio closed this as completed May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants