Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use block.timestamp instead of block.number for Governance contracts #3353

Closed
z0r0z opened this issue Apr 24, 2022 · 3 comments
Closed

use block.timestamp instead of block.number for Governance contracts #3353

z0r0z opened this issue Apr 24, 2022 · 3 comments

Comments

@z0r0z
Copy link
Contributor

z0r0z commented Apr 24, 2022

🧐 Motivation
Improve cross-chain composability.

📝 Details
block.number -> .timestamp
@Amxx
Copy link
Collaborator

Amxx commented Apr 24, 2022

Hello @z0r0z

This is definitely something we are aware of, and concerned by:

https://twitter.com/amxx/status/1517413201067053056?t=gIIw6L9XIlFys2dQHXfCmg

Fixing it is hard, because it reaches into the tokens that are used for voting. We don't want a quick fix, we want something clean and safe. That will come, but it will take some time to get right.

@z0r0z
Copy link
Contributor Author

z0r0z commented Apr 25, 2022

Thanks for the thoughtful response @Amxx

@frangio
Copy link
Contributor

frangio commented May 4, 2022

Duplicate of #3081

@frangio frangio marked this as a duplicate of #3081 May 4, 2022
@frangio frangio closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frangio @Amxx @z0r0z