Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include address(this) when computing Governor proposal ids #3926

Closed
frangio opened this issue Jan 4, 2023 · 1 comment
Closed

Include address(this) when computing Governor proposal ids #3926

frangio opened this issue Jan 4, 2023 · 1 comment
Labels
area: governance breaking change Changes that break backwards compatibility of the public API.
Milestone
[Archived] 5.0

Comments

@frangio
Copy link
Contributor

frangio commented Jan 4, 2023

From #2961.

Governor proposal ids are hashes of the proposal parameters, but they are currently not scoped to the governor contract itself. This issue is about scoping them by including address(this) in the hash.
@frangio frangio added the breaking change Changes that break backwards compatibility of the public API. label Jan 4, 2023
@frangio frangio added this to the 5.0 milestone Jan 4, 2023
@frangio frangio mentioned this issue Jan 4, 2023
Closed
@Amxx
Copy link
Collaborator

Amxx commented Jun 8, 2023 •
edited
Loading

As mentioned on linear, this is going to be breaking frontend. The rational is unclear to me. Why do we want that ?

@Amxx Amxx closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: governance breaking change Changes that break backwards compatibility of the public API.
Projects
None yet
Milestone
[Archived] 5.0
Development

No branches or pull requests
2 participants
@frangio @Amxx