Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a findLowerBound function to the Arrays library #4744

Closed
Amxx opened this issue Nov 16, 2023 · 5 comments · Fixed by #4842
Closed

Add a findLowerBound function to the Arrays library #4744

Amxx opened this issue Nov 16, 2023 · 5 comments · Fixed by #4842
Labels
Datastructures feature New contracts, functions, or helpers. idea

Comments

@Amxx
Copy link
Collaborator

Amxx commented Nov 16, 2023

Has request by @alanarvelo during DevConnect, we should add a lower lookup function to Arrays.sol. This is already available in Checkpoints but is missing from Arrays.

@Amxx Amxx added feature New contracts, functions, or helpers. idea labels Nov 16, 2023
@Amxx Amxx added this to the 5.1 milestone Nov 16, 2023
@basefee
Copy link

basefee commented Nov 26, 2023

Does this issue also require writing test case for the new function?

@kamuikatsurgi
Copy link

Hey! I can contribute to this, can someone explain me what exactly is needed for the findLowerBound function in Arrays.sol library? @Amxx

@Amxx
Copy link
Collaborator Author

Amxx commented Dec 15, 2023

@kamuikatsurgi we already have an implementation and are discussing backward compatibility issues.
Thank you for your proposal though

@kamuik16
Copy link

@kamuikatsurgi we already have an implementation and are discussing backward compatibility issues. Thank you for your proposal though

Hey @Amxx, any beginner friendly or good first issue I can work on right now?

@Amxx
Copy link
Collaborator Author

Amxx commented Dec 15, 2023

@kamuik16 nothing really comes to mind right now. We have some ideas for new features, but they are quite difficult/tricky to figure out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datastructures feature New contracts, functions, or helpers. idea
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@Amxx @kamuik16 @kamuikatsurgi @basefee and others