Add Governor extension GovernorNoncesKeyed to use NoncesKeyed for vote by sig
#5574
+411
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d5295cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
lgtm |
Amxx
reviewed
Mar 12, 2025
Amxx
reviewed
Mar 12, 2025
Amxx
reviewed
Mar 12, 2025
arr00
changed the title
NoncesKeyed for Governor votes by sig with proposalId as the key.GovernorNoncesKeyed to use NoncesKeyed for vote by sig
|
I like the new version! We'll need a changelog entry and full coverage, but this will be for 5.4 anyway so no rush. |
0xy0k
reviewed
Mar 25, 2025
| @@ -198,31 +198,35 @@ describe('Governor', function () { | |||
| }); | |||
|
|
|||
| describe('vote with signature', function () { | |||
There was a problem hiding this comment.
what about adding stress test edge cases (e.g. signature replay on multiple proposals) or extend the extension to support batch signatures per user?
arr00
force-pushed
the
feat/governor-keyed-nonces
branch
from
695a960 to
d5295cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5565
PR Checklist
npx changeset add)