Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SafeMath to support signed int operations #705

Closed
1 task done
facuspagnuolo opened this issue Jan 24, 2018 · 2 comments · Fixed by #1559
Closed
1 task done

Improve SafeMath to support signed int operations #705

facuspagnuolo opened this issue Jan 24, 2018 · 2 comments · Fixed by #1559
Assignees
@facuspagnuolo
Labels
feature New contracts, functions, or helpers.

Comments

@facuspagnuolo
Copy link
Contributor

facuspagnuolo commented Jan 24, 2018 •
edited
Loading

  • 📈 This is a feature request.

The idea is to provide basic math operations (like add, sub, mul, etc) for signed integers. I think this could be added within SafeMath itself.
@cedricwalter cedricwalter mentioned this issue Jan 29, 2018
Closed
4 tasks
@cedricwalter
Copy link

see #714

@federicobond federicobond added feature New contracts, functions, or helpers. in progress labels Feb 8, 2018
@facuspagnuolo facuspagnuolo self-assigned this Feb 15, 2018
@facuspagnuolo facuspagnuolo mentioned this issue Mar 23, 2018
Closed
@come-maiz come-maiz mentioned this issue May 11, 2018
Closed
@shrugs shrugs added in progress and removed review labels Jul 18, 2018
@wbt
Copy link

wbt commented Oct 25, 2018

Just to create a cross-reference, PR#1484 expands on SafeMath for uint32s, which overflow at somewhat less astronomical values but don't have all the new potential issues that signed integers introduce.

@frangio frangio mentioned this issue Dec 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facuspagnuolo facuspagnuolo

Labels
feature New contracts, functions, or helpers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Signed SafeMath frangio/openzeppelin-contracts
Improve safemath signed int
5 participants
@federicobond @wbt @cedricwalter @shrugs @facuspagnuolo