Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Move initializers executions into the proxy constructor logic #100

Closed
facuspagnuolo opened this issue Sep 18, 2018 · 0 comments
Closed

Move initializers executions into the proxy constructor logic #100

facuspagnuolo opened this issue Sep 18, 2018 · 0 comments
Assignees
Labels
kind:refactor Refactoring of existing code preserving functionality topic:contracts Smart contracts in SDK topic:upgrades Contract upgrades
Milestone

Comments

@facuspagnuolo
Copy link
Contributor

Currently, when a new proxy is created by the UpgradeabilityProxyFactory it is first instantiated and then initialized. We can move the initializer method call within the constructor logic of the Proxy.

Note that we can do the same for the proxy upgrades.
This will allow us to deprecate the proxy factories.
This issue could be considered as part of zeppelinos/zos-lib#210

@facuspagnuolo facuspagnuolo added kind:refactor Refactoring of existing code preserving functionality topic:upgrades Contract upgrades labels Sep 18, 2018
@facuspagnuolo facuspagnuolo self-assigned this Sep 18, 2018
@facuspagnuolo facuspagnuolo added the topic:contracts Smart contracts in SDK label Sep 19, 2018
@facuspagnuolo facuspagnuolo added this to the v2.0.0 milestone Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind:refactor Refactoring of existing code preserving functionality topic:contracts Smart contracts in SDK topic:upgrades Contract upgrades
Projects
None yet
Development

No branches or pull requests

1 participant