Refundable post delivery crowdsale #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
frangio
reviewed
Dec 11, 2018
contracts/crowdsale/distribution/PostDeliveryRefundableCrowdsale.sol
Outdated
Show resolved
Hide resolved
|
In this PR we should also add the warning (the "deprecation warning") in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #877
Since this is a
PostDeliveryCrowdsale, tokens will only be granted after it ends, and only if the crowdsale is successful (i.e. the goal is met): therefore, the tokens being issued and purchases being refunded become mutually exclusive scenarios, preventing the issue described.I made the new crowdsale inherit from
RefundableCrowdsale, but if we chose to deprecate it (i.e.pragma deprecatedor something along those lines) we will probably want to copy the logic into this new contract.