Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward all gas on PullPayment withdrawal #1976

Merged
merged 9 commits into from
Oct 28, 2019
Merged

Forward all gas on PullPayment withdrawal #1976

merged 9 commits into from
Oct 28, 2019

Conversation

nventuro
Copy link
Contributor

Fixes #1668.
Replaces #1714.

@nventuro nventuro added feature New contracts, functions, or helpers. contracts Smart contract code. labels Oct 28, 2019
@nventuro nventuro requested a review from frangio October 28, 2019 21:15
@nventuro nventuro mentioned this pull request Oct 28, 2019
Closed
frangio
frangio reviewed Oct 28, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
contracts/payment/PullPayment.sol Show resolved Hide resolved
contracts/payment/PullPayment.sol Outdated Show resolved Hide resolved
contracts/payment/PullPayment.sol Outdated Show resolved Hide resolved
test/payment/PullPayment.test.js Show resolved Hide resolved
frangio
frangio approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nventuro nventuro merged commit d6e10ab into OpenZeppelin:master Oct 28, 2019
@nventuro nventuro deleted the pull-payment-full-gas branch October 28, 2019 23:06
frangio pushed a commit that referenced this pull request Oct 29, 2019
@nventuro @frangio
Forward all gas on PullPayment withdrawal (#1976)
1c220e1 
* Add withdrawWithGas

* Improve docs

* Add changelog entry

* Update contracts/payment/PullPayment.sol

Co-Authored-By: Francisco Giordano <frangio.1@gmail.com>

* Remove repeated comment

* Update changelog entry

* Fix inline docs

* Fix changelog formatting

(cherry picked from commit d6e10ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
contracts Smart contract code. feature New contracts, functions, or helpers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have Escrow forward all gas to recipient
2 participants
@nventuro @frangio