-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PausableCrowdsale contract #832
Added PausableCrowdsale contract #832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @TalAter. This makes sense to me, because just pausing the token doesn't cover all the possible scenarios of crowdsales.
Let's wait for the second review by a fellow maintainer to confirm.
Small update: our crowdsale which used this contract successfully closed last week raising over 40,000 Ether. No issues were found in this trial by fire. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change the inheritance order to is Pausable, Crowdsale
.
…aph impossible" error
Nice catch @amateescu |
@TalAter looking at the Travis CI failures, I think the test coverage from this PR needs to be updated. |
Comply with new max line length
…PausableCrowdsale tests
Brought this branch up to speed with the latest changes done to HEAD.
|
Great work @TalAter! We're wrapping up the 2.0 release candidate this week so I'll get back to this in a few days. |
…y into feature/pausable-crowdsale
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Description
Introduces a new contract, the
PausableCrowdsale
.PausableCrowdsale
extends the standardCrowdsale
contract, making it pausable. This is a useful failsafe mechanism used by many crowdsales, but isn't yet offered byzeppelin-solidity
.buyTokens()
or simple transactions will revert.🦆🦆🦆🦆🦆🦆
npm run lint:all:fix
).