Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RSK to the list of providers that return a revert reason message. #146

Open
core-baguira opened this issue Dec 10, 2020 · 1 comment
Open

Add RSK to the list of providers that return a revert reason message. #146

core-baguira opened this issue Dec 10, 2020 · 1 comment

Comments

@core-baguira
Copy link

core-baguira commented Dec 10, 2020 •
edited
Loading

Hi there,

RSK in it's new version will start supporting revert reason messages. Can we add it so the expectRevert function takes it into account?
Version should be greater than: 2.2.0

An example on how the node info shows is: RskJ/2.2.0/Mac OS X/Java1.8/SNAPSHOT-dev.

Thank you
@frangio
Copy link
Contributor

frangio commented Dec 10, 2020

Can you submit a PR? We also need an integration test. You can look at #131 for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frangio @core-baguira