Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, shared-data, components): add calibration not req text for plate reader, remove lid filtration #16776

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Nov 12, 2024

fix RQA-3396

Overview

Add text that shows plate reader calibration is not needed on device settings calibration on desktop app and remove provision that filtered out the plate reader lid from the UI

Test Plan and Hands on Testing

  1. Look at desktop device settings calibration screen for a device with a plate reader attached
  2. Made sure all NON_USER_ADDRESSABLE_LABWARE that was added in feat(app): Plate reader in LPC and CommandText, filter out plate reader lid as labware #16489 has been correctly removed
Screen Shot 2024-11-12 at 3 14 04 PM

Changelog

  1. Added "No calibration required" copy for plate reader in device settings calibraiton
  2. Removed provision that was added to filter out the absorbance reader lid from UI touchpoints including protocol details, protocol deck map, and protocol setup labware tab since the lid will no longer be implicitly loaded through a loadLabware command after this PR merged 60dca54

Review requests

Verify that we no longer receive loadLabware commands for absorbance reader lid after analysis

Risk assessment

Low

@smb2268 smb2268 marked this pull request as ready for review November 12, 2024 20:54
@smb2268 smb2268 requested a review from a team as a code owner November 12, 2024 20:54
@smb2268 smb2268 requested review from mjhuff, SyntaxColoring and vegano1 and removed request for a team November 12, 2024 20:54
@smb2268 smb2268 self-assigned this Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (chore_release-8.2.0@6ed5aaf). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##             chore_release-8.2.0   #16776   +/-   ##
======================================================
  Coverage                       ?   79.32%           
======================================================
  Files                          ?      120           
  Lines                          ?     4459           
  Branches                       ?        0           
======================================================
  Hits                           ?     3537           
  Misses                         ?      922           
  Partials                       ?        0           
Flag Coverage Δ
shared-data 74.02% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@smb2268 smb2268 requested a review from CaseyBatten November 13, 2024 15:08
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from a FE code perspective!

@smb2268 smb2268 merged commit 653fb49 into chore_release-8.2.0 Nov 13, 2024
70 checks passed
@smb2268 smb2268 deleted the app_plate-reader-cal branch November 13, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants