Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Bubble pipette command errors during drop tip wizard #16793

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Nov 13, 2024

Works toward RQA-3569

Overview

50c314c - Something lower level recently changed that causes blowout commands to fail, but the app was not properly bubbling up the errors specifically related to blowout/drop tip actions during drop tip wizard. This PR fixes that.

6f0c618 - When an error fails during blowout, we show a "you can still drop tips" modal during error recovery. The "proceed to drop tips" CTA should route users directly to the tip drop flow in drop tip wizard, but it was routing to the option to select blowout or drop tips. This commit fixes just that.

Current Behavior

Screenshot 2024-11-13 at 11 53 33 AM

Fixed Behavior

Screen.Recording.2024-11-13.at.12.32.19.PM.mov

Test Plan and Hands on Testing

  • See video.

Changelog

  • Drop tip wizard correctly shows an error screen if an error occurs during the actual blowout or drop tip action.

Risk assessment

low

@mjhuff mjhuff requested review from sfoster1, TamarZanzouri, smb2268 and a team November 13, 2024 18:17
@mjhuff mjhuff requested a review from a team as a code owner November 13, 2024 18:17
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, yeah.

@mjhuff mjhuff merged commit 21bf747 into chore_release-8.2.0 Nov 13, 2024
36 checks passed
@mjhuff mjhuff deleted the app_show-blowout-errors-dt-wiz branch November 13, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants