fix(app): Fix run setup buttons #16796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3578 and RQA-3577
Overview
This PR fixes a few buttons in setup flows on the desktop app.
69e4aa6 - If you hover the LPC button, you can get some unexpected title text. We simply remove the title prop here.
a604458 - We were missing disabled status/tooltips on these two buttons in particular, so this adds them. Left a TODO to consolidate this behavior, since we use it for every step in the setup fows.
Screen.Recording.2024-11-13.at.2.30.05.PM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
low