fix(api): add supported wavelengths to runtime error when initializing the plate reader. #16797
+34
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the plate reader.
ecormany
approved these changes
Nov 13, 2024
api/src/opentrons/protocol_engine/commands/absorbance_reader/initialize.py
Outdated
Show resolved
Hide resolved
…nitialize.py Co-authored-by: Ed Cormany <edward.cormany@opentrons.com>
SyntaxColoring
approved these changes
Nov 13, 2024
sfoster1
requested changes
Nov 13, 2024
| @@ -70,7 +70,10 @@ async def execute(self, params: InitializeParams) -> SuccessData[InitializeResul | |||
| supported_wavelengths | |||
| ) | |||
| if unsupported_wavelengths: | |||
| raise ValueError(f"Unsupported wavelengths: {unsupported_wavelengths}") | |||
| raise ValueError( | |||
There was a problem hiding this comment.
This should be an error from protocol_engine.errors that gets associated with an error code - maybe invalid protocol data, but ok to fall back to 4000 general error instead. If it's just a raw exception it will get a scarier UI.
Also this seems like it's just dumping a set to string which will look like this: "Unsupported wavelengths: {1000, 1400, 1200}. Use one of {500, 800, 1000} instead." Feels a little terse, maybe make it {', '.join([str(wavelength) + 'nm' for wavelength in unsupported_wavelengths]) instead?
…github.com/Opentrons/opentrons into add-supported-wavelengths-to-runtime-error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add the supported wavelengths to the runtime error raised when an invalid wavelength is provided.
Closes: RQA-3568
Test Plan and Hands on Testing
Changelog
InvalidWavelengthErrorto denote incompatible wavelengths with the current plate reader.InvalidWavelengthErrorand format a message to clarify what wavelengths can be used.Review requests
Risk assessment
low, log only change