fix(app): add affordances for tip detection failures #16828
Merged
+80
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
commented
Nov 14, 2024
| const pipettesWithTipAttached = attachedPipettes.filter( | ||
| attachedPipette => | ||
| mountsWithTipAttached.includes(attachedPipette.mount) && | ||
| attachedPipette.ok |
There was a problem hiding this comment.
This is just slightly safer but we really should never be able to get through a protocol with bad pipettes.
mjhuff
force-pushed
the
app_add-error-handling-tip-status
branch
from
a9c5f18 to
af0d840
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3589
Overview
At the end of a protocol run, we execute tip detection logic to determine whether or not we should pop drop tip CTAs. There are a few network requests necessary to make this work, and we are not error handling if any of these requests fail.
This PR adds a general fallback: if almost any network request fails, let's just assume both pipettes have tips attached and pop the CTAs (assuming the pipettes have
okfirmware status). It's probably better to be more conservative here, and in practice, this exact scenario should occur rarely.Note that the very first request we make is to get the currently attached instruments. If this request fails, we can't do drop tip wizard, so we shouldn't show CTAs. The only workaround here would be going to design and coming up with some sort of "can't detect tips" copy. At the very least, the user can always go to drop tip wizard manually and handle tips there.
Test Plan and Hands on Testing
Changelog
Risk assessment
low