fix(api): update error message to title case #16851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecormany
reviewed
Nov 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-8.2.0 #16851 +/- ##
======================================================
Coverage ? 92.43%
======================================================
Files ? 77
Lines ? 1283
Branches ? 0
======================================================
Hits ? 1186
Misses ? 97
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Ed Cormany <edward.cormany@opentrons.com>
SyntaxColoring
approved these changes
Nov 18, 2024
| detail: str = "No tip detected." | ||
| detail: str = "No Tip Detected" |
There was a problem hiding this comment.
OK, but FYI the contract for detail does not say it should be TitleCase. And in fact in many cases it will need to be sentence-case, if it's a couple of sentences long.
TamarZanzouri
deleted the
RQA-3587-flex-error-recovery-view-error-details-error-codes-are-title-case-except-for-no-tip-detected
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes https://opentrons.atlassian.net/browse/RQA-3587.
title case error message
Test Plan and Hands on Testing
reproduce a tip not attached error and make sure when you view the details they are in title case