Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): update air gap aspirate copy, high res mag block image #16890

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Nov 19, 2024

Overview

Copy for quick transfer aspirate air gap setting should read "Air gap after aspirating" and mag block gen1 needs a high res photo version

Test Plan and Hands on Testing

Checked quick transfer copy on ODD, looked at stacking modal for protocol with labware stacked on top of mag block
Screen Shot 2024-11-19 at 1 14 20 PM

Changelog

  1. Add high res option for mag block asset
  2. Swap "before" for "after" in aspirate air gap setting

Review requests

Quick code check

Risk assessment

Low

@smb2268 smb2268 requested a review from mjhuff November 19, 2024 19:08
@smb2268 smb2268 self-assigned this Nov 19, 2024
@smb2268 smb2268 requested a review from a team as a code owner November 19, 2024 19:08
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@smb2268 smb2268 merged commit 2938900 into chore_release-8.2.0 Nov 19, 2024
30 checks passed
@smb2268 smb2268 deleted the app_qt-copy-fix branch November 19, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants