fix(shared-data): Fix migrating mutable pipette configs

[SyntaxColoring]

Overview

Closes RQA-3676.

Test Plan and Hands on Testing

• Change a bunch of pipette settings on an OT-2 and make sure they take effect? It's not clear to me what the user-observable behavior of the bug would have been. Would all the settings have acted as their defaults?
  • In particular, change tip pickup settings?

Changelog

Review requests

Is there a more useful test to check that could check the correctness of the result, not merely that no exceptions are logged?

Risk assessment

I (Max) think this is high-risk because I understand maybe 40% of it. Those more familiar with the code might find it less worrying.

[SyntaxColoring]

Does this other function need the same change?

opentrons/shared-data/python/opentrons_shared_data/pipette/load_data.py

Lines 169 to 200 in efb4f42

	def _edit_non_quirk_with_lc_override(
	mutable_config_key: str,
	new_mutable_value: Any,
	base_dict: Dict[str, Any],
	liquid_class: Optional[LiquidClasses],
	) -> None:
	def _do_edit_non_quirk(
	new_value: Any, existing: Dict[Any, Any], keypath: List[Any]
	) -> None:
	thiskey: Any = keypath[0]
	if thiskey in [lc.name for lc in LiquidClasses]:
	if liquid_class:
	thiskey = liquid_class
	else:
	thiskey = LiquidClasses[thiskey]
	if len(keypath) > 1:
	restkeys = keypath[1:]
	if thiskey == "##EACHTIP##":
	for key in existing.keys():
	_do_edit_non_quirk(new_value, existing[key], restkeys)
	else:
	_do_edit_non_quirk(new_value, existing[thiskey], restkeys)
	else:
	# This was the last key
	if thiskey == "##EACHTIP##":
	for key in existing.keys():
	existing[key] = new_value
	else:
	existing[thiskey] = new_value
	new_names = _MAP_KEY_TO_V2[mutable_config_key]
	_do_edit_non_quirk(new_mutable_value, base_dict, new_names)

[sfoster1]

works for me. very confused though