Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid EthersConnector #4

Open
Namaskar-1F64F opened this issue Jan 23, 2023 · 0 comments
Open

Invalid EthersConnector #4

Namaskar-1F64F opened this issue Jan 23, 2023 · 0 comments

Comments

@Namaskar-1F64F
Copy link

Hiya, found your EthersConnector when trying to make 1Inch work, but noticed this does not work and wanted to let ya'll know:

delete typedData.types.EIP712Domain;

I think it should be

signTypedData(
    walletAddress: string,
    typedData: EIP712TypedData,
    _typedDataHash: string,
  ): Promise<string> {
    // Specifically remove EIP712Domain when signing as ethers automatically computes it
    // However, it is necessary exist on the object when hashing
    const { EIP712Domain, ...types } = typedData.types
    return this._signer._signTypedData(typedData.domain, types, typedData.message)
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant