Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a custom role instead of edit ClusterRole #9

Open
hisener opened this issue Feb 25, 2021 · 2 comments
Open

Create a custom role instead of edit ClusterRole #9

hisener opened this issue Feb 25, 2021 · 2 comments

Comments

@hisener
Copy link

hisener commented Feb 25, 2021

Halyard role binding uses default ClusterRole edit, but it allows read/write access to most objects (kubectl describe clusterrole edit). Would it be possible to create a Role object with only required privileges?

spinnaker-helm/templates/rbac/rolebinding.yaml

Lines 7 to 10 in 2a0f39e

roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: edit

Best.
@abhinaybyrisetty
Copy link
Contributor

I have a fix for this, I'll be creating a PR soon

@philleonard
Copy link

Hey @abhinaybyrisetty. Thanks for picking this up! Do you have an update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philleonard @hisener @abhinaybyrisetty