-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add callouts in all the documentation when incompatibility with ODS #1199
Comments
2 tasks
Closed
Closed
This was referenced Nov 10, 2022
20 tasks
Merged
16 tasks
This was referenced Apr 13, 2023
This was referenced Jun 5, 2023
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some components (or some variants of them) are inherited from Bootstrap and should not be used in Orange websites.
To avoid an extra maintenance or simply to let the developer understand how some attributes or variants are possible, we keep what's from Bootstrap documentation.
So we use callouts as an information for the users to know that. This is an example for the Navbar component:
ℹ️ All callouts must use this template which is in
site/layouts/shortcodes/ods-incompatibility-alert.html
file.The description text of the callout needs to be written in the component .md file. It has to be adapted for each different case. Try as much as possible to use the same description texts for similar cases.
This epic story will contain the list of pages and components that should have those callouts.
List of pages or components
=> For the moment, there is a unique callout template with a "danger" alert icon. So do not take into account the fact that is it written below "Add warning" alert or "Add danger alert".
💡 To discuss with the design:
Instead of using the Alert/Warning icon, it might be more efficient and clear to have an icon representing ODS or at least letting know that this callout targets a design topic and not a technical one.
This idea was implemented in Boosted V4.3 with this message on the Introduction page introducing these Docs callouts:
and the use of the icon where needed in the Docs pages:
=> In the ℹ️ description text proposals below, the ones in bold are the one put in the code at the moment.
ℹ️ Proposed description text:
Note : The entire Boosted doc is preserved and enhanced when necessary with Orange brand specifics, i.e. navbar page contains unsupported features, check out navbar orange page to find out what to use.
docs/5.1/customize/color/
ℹ️ Proposed description texts to choose from:
docs/5.1/content/reboot/ --> 🆕 in V5.2
#horizontal-rules: Add warning alert saying "Variants 3 and 4 can't be used."
ℹ️ Proposed description texts to choose from:
Specifications done by the design:
Those specifications are the ones of the "Lines" and "Outline" in ODS. There is no chapter for then because they are components variants. For example, the blue outline is the outline of the Alert component.
docs/5.3/content/tables/ --> 🆕 2023-05-12 - Fix in PR Docs > Content > Tables: Add design callout messages #2032
#accented-tables: Add info alert saying that it's possible use striped rows OR striped columns, but not both in a same table.
ℹ️ Proposed description texts to choose from:
#nesting: Add danger alert saying that it's not possible to use this variant for usability reasons.
ℹ️ Proposed description texts to choose from:
docs/5.1/forms/overview
#form-text:
Add danger alert saying "In the Orange Design System, the input field label must be placed above the input field. Any other place is not correct + say to go to the Forms/Layout page/#horizontal-form where it will be explained that it is not possible to have horizontal labels in ODS)."
ℹ️ Proposed description texts to choose from:
Disabled field example: Add danger alert saying that in Orange Design System, we can't have a placeholder in an inactive input field.⚠️ : Issue on hold. This issue needs to be discussed between Cyriaque and Julien (interesting to keep the placeholder from a technical point of view, but not from a usability one)
#required-field:
Add danger alert saying "The dropdown part of this component can not be used as it is. Instead use the component Dropdowns at docs/5.1/components/dropdowns/."
ℹ️ Proposed description texts to choose from:
docs/5.1/forms/form-control
#readonly-plain-text: Add warning alert saying "The way this component works technically is OK, but this component can not be use as it is from a design point of view. It needs to be previously modified by a designer from Boosted team. If you If you really need it, ask us for that on Mattermost."
ℹ️ Proposed description texts to choose from:
docs/5.1/forms/select
#default: Add danger alert saying "The dropdown part of this component can not be used as it is. Instead use the component Dropdowns at docs/5.1/components/dropdowns/." + possibly add the existing sentence "Custom
<select>
menus need only a custom class..."ℹ️ Proposed description texts to choose from:
#sizing: Add danger alert saying "The dropdown part of this component can not be used because it does no respect the Orange Design System specifications. Instead, use the component Dropdowns at docs/5.1/components/dropdowns/."
ℹ️ Proposed description texts to choose from:
#disabled: Add danger alert saying "In Orange Design System, these components can not be used. =>⚠️ Alert message to delete once the design will be corrected. See Issue Docs > Forms > Select > Disabled: Fix disabled select dropdown design #1362
ℹ️ Proposed description texts to choose from:
docs/5.1/forms/checks-radios (added during review done: 25th Nov 2022)
ℹ️ Proposed description text:
docs/5.1/forms/input-group
#basic-example: Add danger alert saying "This component can not be used as it is."
ℹ️ Proposed description texts to choose from:
#multiple-input: Add danger alert saying "This component can not be used."
ℹ️ Proposed description texts to choose from:
#multiple-addons: Add danger alert saying "This component can not be used. Here, it only shows how to do such a component from a technical point of view."
ℹ️ Proposed description text to choose from:
#button-addons: Add danger alert. 🆕 2022-12-13
ℹ️ Proposed description text:
These variants should not be used because they do not respect the Orange Design System specifications. They are not recommended for usability reasons.
Please refer to the Forms guidelines and to the Pages form examples on the Orange Design System website.
#buttons-with-dropdowns: Add danger alert saying "This component can not be used (usability reasons)"
ℹ️ Proposed description texts to choose from:
#custom-select: Add danger alert saying "The 3 first examples of this component can not be used."
ℹ️ Proposed description texts to choose from :
#custom-file-input: Add warning alert saying it is ok to use these components but only it they are created using unitary ODS components such as standard buttons, input fields + having a minimum margin of 10px between input fields and buttons."
ℹ️ Proposed description texts to choose from:
docs/5.1/forms/layout
#gutters: Add warning alert saying that the dropdown list of this example (
<select> <option>
) is the one generated by the browser and that for the moment, it cannot be replaced by the Dropdowns component (<ul><li>
), for both are technically different, with an impact on behavior and accessibility.ℹ️ Proposed description texts to choose from:
#horizontal-form: Add warning alert saying "This example is a module, not a single component and it must be build using unitary Orange Design System components. Check correct ODS examples on ODS/Pages/Forms at https://system.design.orange.com/0c1af118d/p/20500e-form/b/16bb53 + in ODS, it's not possible to have labels on the side of the input field "
ℹ️ Proposed description texts to choose from:
**#horizontal-form-label-sizing: Add a warning alert saying that the labels must be placed above the fields, and not on the same line.
ℹ️ Proposed description texts to choose from:
#auto-sizing: Add warning alert saying "This example is a module, not a single component and it must be build using unitary Orange Design System components. Check correct ODS examples on ODS/Pages/Forms at https://system.design.orange.com/0c1af118d/p/20500e-form/b/16bb53 "
ℹ️ Proposed description texts to choose from:
#inline-forms: Add warning alert saying "This example is a module, not a single component and it must be build using unitary Orange Design System components. Check correct ODS examples on ODS/Pages/Forms at https://system.design.orange.com/0c1af118d/p/20500e-form/b/16bb53 "
ℹ️ Proposed description texts to choose from:
docs/5.1/forms/validation. 🆕 2022-12-14 we decided to delete this callout because except the checkbox "Agree terms and conditions" in which the label should be a link (and therefore appear underlined), the form is OK.
#custom-styles: Add warning alert saying "This example is a module, not a single component and it must be build using unitary Orange Design System components. Check correct ODS examples on ODS/Pages/Forms at https://system.design.orange.com/0c1af118d/p/20500e-form/b/16bb53 "
ℹ️ Proposed description texts:
#server-side: Add warning alert saying "This example is a module, not a single component and it must be build using unitary Orange Design System components. Check correct ODS examples on ODS/Pages/Forms at https://system.design.orange.com/0c1af118d/p/20500e-form/b/16bb53"
ℹ️ Proposed description texts to choose from:
#browser-defaults: Add danger alert saying "In Orange Design System, this component can't be used. To add an alert message to an input field, use the Orange Design Alerts component"
ℹ️ Proposed description texts to choose from:
docs/5.1/components/back-to-top
⚠️ This variant was removed from the documentation following designers request. ⚠️
_- [ ] #label-inside: Add danger alert saying "This component can not be used."
ℹ️ Proposed description texts to choose from:
> 1- This example can not be used as it is because it does not respect the Orange Design System specifications.
Refer to the back to top component on ODS website.
docs/5.1/components/badge
#headings: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#buttons: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#positioned: Add warning alert saying "This component can be used but only inside a header component" + put a link towards the corresponding header variant + say to use the Tags component that will be added later in Boosted.
ℹ️ Proposed description text:
#background-colors: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#pill-badges: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
docs/5.1/components/breadcrumb
ℹ️ Proposed description texts:
docs/5.1/components/buttons
#sizes: The custom size is not allowed in ODS => The sentence "It is not recommended by Orange Design System..." needs to be replaced by the dedicated Alert/Warning message.
ℹ️ Proposed description texts to choose from:
#block-buttons: For the 1st example (buttons that are of the length of the screen), add warning alert saying "In ODS, it is not allowed to have buttons of the length of the screen in desktop screens."
ℹ️ Proposed description texts to choose from:
#button-plugin: Add danger alert saying "In ODS, it is not allowed to use only one toggle button. Watch out: The component named "toggle buttons" in Boosted is not the same component as the one in ODS which behaves like a radio button". NOTE: Cyriaque will be asked for renaming this component in ODS. Not done yet.
ℹ️ Proposed description texts to choose from:
docs/5.1/components/button-group
#mix-styles: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#checkbox-and-radio-button-groups: Add danger alert saying "This component can not be used. Use ODS checkboxes instead."
ℹ️ Proposed description text:
#button-toolbar: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#nesting: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#vertical-variation: For all examples, add danger alert saying "These components can not be used, included split buttons"
ℹ️ Proposed description text:
docs/5.1/components/card -⚠️ ON HOLD
Do not address the issues below because:
- Maybe, we'll replace some or all the points below by a single alert message indicating that to build ODS cards, one should visit the Boosted Examples page.
- Some points need to be seen with Cyriaque
docs/5.1/components/carousel
ℹ️ Proposed description text:
docs/5.1/components/collapse
Before #example: Add danger alert saying "Any following variant of this component can not be used." Reason: in ODS, no collapse behavior allowed to be triggered from a button component
ℹ️ Proposed description texts to choose from:
docs/5.1/components/dropdowns
#single-button: Add danger alert saying that it is strongly recommended to use a⚠️ Maybe to modify or delete because it's more a technical information that a design one.
<button>
html tag for the dropdown field and that if one wants to use an<a>
tag instead, it is then necessary to add some code to make it ok for accessibility. See PR HTML semantic of dropdown menu #1412. =>ℹ️ Proposed description text:
Before #sizing: Before the small buttons examples, add danger alert saying "This component can not be used." Reason: in ODS, no such size available for this component.
ℹ️ Proposed description texts to choose from:
#centered: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#dropup-centered: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#text: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#forms: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#dropdown-options: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#auto-close-behavior: Add danger alert saying "The variants Clickable outside, Clickable inside and Manual close can be used ONLY with multiple selections and not single selection as illustrated here."
ℹ️ Proposed description text:
docs/v5.1/components/list-group
numbered: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
horizontal: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
flush: It might be useful to add a design callout saying that this flush variant shall be used inside a container with a top and a bottom border, to have at the end the same design as illustrated on the design specifications. See PR List-group: Branded #1466
contextual-classes: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
with-badges: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
custom-content: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#checkboxes-and-radios: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
docs/5.1/components/modal
#scrolling-long-content: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#using-the-grid: Add danger alert saying "This component can not be used."
⚠️ CALLOUT MESSAGE DELETED IN FINE (decided when reviewing the PR)
ℹ️ Proposed description text:
#varying-modal-content: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#toggle-between-modals: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#fullscreen-modal: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
docs/5.1/components/navs-tabs
#pills: Add danger alert saying "This component can not be used." Reason: its a button component in ODS
ℹ️ Proposed description text:
#fill-and-justify: Add danger alert saying "This component can not be used." Reason: its a button component in ODS
ℹ️ Proposed description text:
#working-with-flex-utilities: Add danger alert saying "This component can not be used." Reason: its a button component in ODS
ℹ️ Proposed description text:
#pills-with-dropdowns: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
docs/5.1/components/progress
#labels: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#height: For the narrowest progress bar, add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#backgrounds: Add danger alert saying "This component can be used only with the background color #ff7900. All other colors are not allowed in ODS".
ℹ️ Proposed description text:
#multiple-bars: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#striped: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
#animated-stripes: Add danger alert saying "This component can not be used."
ℹ️ Proposed description text:
docs/5.1/components/tooltips
ℹ️ Proposed description text:
🚨 Comments from Boosted users
=> Different possibilities to counter that:
1- Rewording the content of the callouts.
Example of new callouts content: just say "Incompatibility with the Orange Design System" + link "More info", this link going to a page (intro?) in which it would be explained that being based on Bootstrap, Boosted docs offers components or components variants that are not recommended in ODS
2- Adding a tag in front of each unitary example meaning "OK to use", "Use but with some changes needed, "Don't use"
3- Removing all doc part that is not correct from ODS point of view (pb: hide technical possibilities that could be useful even though the design shall be adapted to match ODS spec + make the document lose part of its reading logic).
4- Adding directly usable code in ODS components
5- Having for each component a dedicated Orange page - as for Navbar and Orange Navbar - with only the content that is possible to use respecting ODS specs.
References in other issues
Sub-task
The text was updated successfully, but these errors were encountered: