Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement isDate predicate #1520

Closed
jcamiel opened this issue May 5, 2023 · 4 comments
Closed

Implement isDate predicate #1520

jcamiel opened this issue May 5, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone
4.1.0

Comments

@jcamiel
Copy link
Collaborator

jcamiel commented May 5, 2023

Since 3.0.0, dates are first type citizen in Hurl format. As there are isFloat, isInteger, isString, isCollection predicates, we could add isDate:

GET https://example.org
HTTP 200
[Asserts]
certificate "Expire-Date" isDate == true
@jcamiel jcamiel added the enhancement New feature or request label May 5, 2023
@guilherme-puida
Copy link
Contributor

I'd like to work on this if there isn't anyone else currently implementing this :^)

@jcamiel
Copy link
Collaborator Author

jcamiel commented Jun 30, 2023

Hi @guilherme-puida you can work on it if you want, there is nobody for the moment! We've a contributing guide to help you start if you want, and also some documentation on how we test Hurl. Don't hesitate to give us feebacks on the source code, onboarding on the project etc... Thanks for your help!

@guilherme-puida
Copy link
Contributor 

GET https://example.org
HTTP 200
[Asserts]
certificate "Expire-Date" isDate == true

Is this correct? Looking at the isInteger/... docs I assumed it would be just certificate "Expire-Date" isDate (without the == true).

@jcamiel
Copy link
Collaborator Author

jcamiel commented Jul 2, 2023

No you're right, it's just isDate!

GET https://example.org
HTTP 200
[Asserts]
certificate "Expire-Date" isDate

@jcamiel jcamiel added this to the 4.1.0 milestone Jul 3, 2023
@guilherme-puida guilherme-puida mentioned this issue Jul 10, 2023
Closed
@jcamiel jcamiel closed this as completed Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

Implement isDate predicate guilherme-puida/hurl
2 participants
@jcamiel @guilherme-puida