Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Cookies Section should not change cookie store #25

Closed
fabricereix opened this issue Sep 21, 2020 · 2 comments
Closed

Request Cookies Section should not change cookie store #25

fabricereix opened this issue Sep 21, 2020 · 2 comments
Assignees
@fabricereix @jcamiel
Milestone
0.99.0

Comments

@fabricereix
Copy link
Collaborator

fabricereix commented Sep 21, 2020 •
edited
Loading

Cookies defined the request Cookies section should just add cookies in the request but should not change cookie storage.
This is consistent with curl.

For example: Send cookie1 in the request and cookie2 set from server endpoind

$ curl \
    --cookie cookie1=value1 \
    --cookie-jar /tmp/cookies \
    http://httpbin.org/cookies/set/name2/value2
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<title>Redirecting...</title>
<h1>Redirecting...</h1>
<p>You should be redirected automatically to target URL: <a href="/cookies">/cookies</a>. ..

$ cat /tmp/cookies 
# Netscape HTTP Cookie File
# https://curl.haxx.se/docs/http-cookies.html
# This file was generated by libcurl! Edit at your own risk.

httpbin.org	FALSE	/	FALSE	0	name2	value2

with the current hurl

$ cat <<END | hurl --cookie-jar /tmp/cookies
GET http://httpbin.org/cookies/set/cookie2/value2
[Cookies]
cookie1: value1
END

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<title>Redirecting...</title>
<h1>Redirecting...</h1>
<p>You should be redirected automatically to target URL: <a href="/cookies">/cookies</a>...

$ cat /tmp/cookies 
# Netscape HTTP Cookie File
# This file was generated by hurl

httpbin.org	FALSE	/	FALSE	0	cookie1	value1
httpbin.org	FALSE	/	FALSE	0	cookie2	value2
@fabricereix fabricereix changed the title Request Cookies Section Request Cookies Section should not change cookie store Sep 21, 2020
@fabricereix
Copy link
Collaborator Author

there was already the following issue
#2

@fabricereix fabricereix mentioned this issue Sep 23, 2020
Merged
@fabricereix
Copy link
Collaborator Author

fix in #29

@lepapareil lepapareil added this to the 0.99 milestone Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabricereix fabricereix

@jcamiel jcamiel

Labels
None yet
Projects
None yet
Milestone
0.99.0
Development

No branches or pull requests
3 participants
@fabricereix @lepapareil @jcamiel