-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Url parsing: align parsing implementation with grammar #3244
Comments
@jcamiel @lepapareil
|
Both seem OK! You can also do some "git blaming" on the function that checks the http/https prefix to see why we added it: I remember adding an integration test for it but don't remember what has triggered it... |
Can't we just outsource the validation to curl? Just give it to curl and see if it accepts it. |
There are some logic regarding redirection where we must transform the value of the url to an |
I think the |
In the Hurl grammar, URL is parsed as:
Where
value-string
is a "common" token : in particular, asvalue-string
, URL should accept Hurl unicode literals (ex:\u{7b}
), or curly braces ({
). Related to discussion #3243, we should accept the following Hurl file where the URL contains{
and}
without being URL encoded:The text was updated successfully, but these errors were encountered: