Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for bad url #662

Closed
jcamiel opened this issue Jul 6, 2022 · 0 comments · Fixed by #820
Closed

Improve error message for bad url #662

jcamiel opened this issue Jul 6, 2022 · 0 comments · Fixed by #820
Labels
enhancement New feature or request
Milestone

Comments

@jcamiel
Copy link
Collaborator

jcamiel commented Jul 6, 2022

Given the following (invalid) Hurl file:

GET "https://example.org"

We get this error message:

$ echo 'GET "https://example.org"' | hurl
error: Error { pos: Pos { line: 1, column: 5 }, recoverable: false, inner: Url }
  --> -:1:5
   |
 1 | GET "https://example.org"
   |     ^ Error { pos: Pos { line: 1, column: 5 }, recoverable: false, inner: Url }
   |

Maybe we can improve the message for this "common" case (and not leak Error inner structure).

@jcamiel jcamiel added the enhancement New feature or request label Jul 6, 2022
@jcamiel jcamiel added this to the 1.7.0 milestone Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant