Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go 1.13 error wrap feature #9

Open
gfeun opened this issue Mar 12, 2020 · 0 comments
Open

Use Go 1.13 error wrap feature #9

gfeun opened this issue Mar 12, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@gfeun
Copy link
Contributor

gfeun commented Mar 12, 2020

We have our own error wrapping mechanism that wraps Vault error inside our custom RksError struct.

We should take advantage of Go 1.13 error wrap feature to be more idiomatic and make error handling clearer

We should also refactor our error handling to return go standard error type and not our RksError
@gfeun gfeun added the enhancement New feature or request label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gfeun