Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screensave doesn't stop by any button press #100

Closed
VasilisPat opened this issue Oct 7, 2022 · 7 comments
Closed

Screensave doesn't stop by any button press #100

VasilisPat opened this issue Oct 7, 2022 · 7 comments
Labels
bug Something isn't working
Milestone

Comments

@VasilisPat
Copy link
Contributor

Describe the bug
Screensaver does not terminate after any keyboard or mouse press.

Expected behavior
Terminate aerial on any button press, mimic Window's screensaver action.

Aerial Version
Aerial v1.0.0

@VasilisPat VasilisPat added the bug Something isn't working label Oct 7, 2022
@OrangeJedi
Copy link
Owner

Ouch. I've seen this happen once or twice on my computer after I released v1.0.0, but it doesn't happen consistently. Have you been able to consistently reproduce the error?

@VasilisPat
Copy link
Contributor Author

Yes, alomst every time. The only way to exit seems to be alt+f4 or windows+d.

@OrangeJedi
Copy link
Owner

I'm going to try to re-produce the error on my end. Do you have the lock computer after running setting turned on? Have you opened an Aerial preview window since the last time Aerial was started?

@VasilisPat
Copy link
Contributor Author

No, the lock computer option is left disabled and preview wasn't opened.

@OrangeJedi
Copy link
Owner

Okay, there was definitely an issue where if the preview windows was opened and the screensaver started up later that Aerial wouldn't quit. I added the code to fix this in the v1.0.1 branch, but I don't know if that was the specific issue. If you have a node.js environment setup you could test this yourself.

If you quit Aerial (right click on the tray icon, then restart the program) and then immediately start the screensaver via the tray menu does the issue still happen?

@OrangeJedi OrangeJedi added this to the v1.1.0 milestone Oct 7, 2022
@OrangeJedi OrangeJedi modified the milestones: v1.1.0, v1.0.1 Oct 7, 2022
@VasilisPat
Copy link
Contributor Author

Tried exiting the application and restarting Aerial without running preview. When the screensaver automatically kicks in, sometimes any keypress would stop the playback but other times it would act as if nothing happened. So I think that running the preview had some association with it, but there is something else too hiding underneath.

@OrangeJedi
Copy link
Owner

Thanks! I fixed the preview patch in v1.0.1 and added a few small changes decrease the likelihood of this happening. Let me know if updating Aerial fixes the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants