Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run gulp pipeline as part of the CI #11916

Closed
sebastienros opened this issue Jun 28, 2022 · 2 comments · Fixed by #15735
Closed

Run gulp pipeline as part of the CI #11916

sebastienros opened this issue Jun 28, 2022 · 2 comments · Fixed by #15735
Milestone

Comments

@sebastienros
Copy link
Member

Run the gulp pipeline and check the result is the same as the checked-in file to ensure the PR correctly ran it if there were changes in js/css.

c.f. https://github.com/OrchardCMS/OrchardCore/pull/11893/files

@sebastienros sebastienros added this to the 1.x milestone Jun 30, 2022
@0liver
Copy link
Contributor

0liver commented Jan 27, 2023

This should be addressed soon, because with a fresh clone of OC, using Node.js 16 + NPM 8, I get 7 modified files compared to what's committed to dev:

image

The changes don't seem substantial, it's only code being moved around, but they are still changes that should be committed.

When using Node.js 14 with NPM 6, the Gulp build actually fails due to NPM dependencies not automatically being installed and Orchard.Setup choking on that because of the missing @popperjs dependency of bootstrap.

@Piedone Piedone pinned this issue Apr 24, 2024
@Piedone Piedone unpinned this issue Apr 24, 2024
@Piedone
Copy link
Member

Piedone commented Apr 24, 2024

This was fixed in #15735.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants