-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The creation time of workflow is not intuitive enough #12070
Comments
Do we really show time zone, coz this is the first time I notice that ;) |
Here the "concern" is the usage by design of our coded OrchardCore/src/OrchardCore/OrchardCore.DisplayManagement/Shapes/DateTimeShapes.cs Lines 35 to 46 in c255456
@hyzx86 would prefer the usage of our OrchardCore/src/OrchardCore/OrchardCore.DisplayManagement/Shapes/DateTimeShapes.cs Lines 83 to 87 in c255456
|
🤣This is the first time I use shape.. Refer to official documents https://docs.orchardcore.net/en/dev/docs/reference/core/Placement/#datetime I use it this way, I don't konw why it is empty .. |
You might need to override the shape |
Done ,but that will be show a correct time , 8 hours missing.. Looks like the <span class="hint">@T["Created"]@await DisplayAsync(await New.DateTime(entry.Workflow.CreatedUtc, Format: "yyyy-MM-dd hh:mm:ss"))</span>
@* <span class="hint">@T["Created: {0}", await LocalClock.ConvertToLocalAsync(entry.Workflow.CreatedUtc)]</span> *@
@if (entry.Workflow.State.ContainsKey("LastExecutedOn")
&& entry.Workflow.State["LastExecutedOn"] is not null
&& DateTime.TryParse(entry.Workflow.State["LastExecutedOn"].ToString(), out var lastExecutedOn))
{
lastExecutedOn = DateTime.SpecifyKind(lastExecutedOn, DateTimeKind.Utc);
<span class="hint">@T["| Last Executed: {0}", await LocalClock.ConvertToLocalAsync(lastExecutedOn)]</span>
} |
@hyzx86 why you didn't set a proper time zone |
In my orginal code ,it is work well <span class="hint">@T["Created {0}", await LocalClock.ConvertToLocalAsync(entry.Workflow.CreatedUtc)]</span> The following code also uses OrchardCore/src/OrchardCore/OrchardCore.DisplayManagement/Shapes/DateTimeShapes.cs Lines 83 to 94 in c255456
|
What you wanna undo? |
Suggestion: Change this line: With
|
In the current list of workflow instances, the process creation time is not intuitive enough. We only can open a detailed page to check the exact execution time
I adjusted the time format of the list page to make it consistent with the details page

@Skrypt
If necessary, I can submit a PR,Or you can update directly with the following code
The text was updated successfully, but these errors were encountered: