Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmailTask breaking change #13742

Closed
hyzx86 opened this issue May 25, 2023 · 1 comment · Fixed by #13743
Closed

EmailTask breaking change #13742

hyzx86 opened this issue May 25, 2023 · 1 comment · Fixed by #13743
Labels
Milestone

Comments

@hyzx86
Copy link
Contributor

hyzx86 commented May 25, 2023

The PR #13426 will cause some problems,

I had a workflow that I created 2 years ago, and I wasn't sure which field would be the body of the email, so I wrote it in both places

The Settings below used to use 'Body' as the body of the email. After updating the OC version, it found that it used 'BodyText' as the body

            {
              "ActivityId": "472xt4dht0zxq2p4hqc5f8a850",
              "Name": "EmailTask",
              "X": 950,
              "Y": 1300,
              "IsStart": false,
              "Properties": {
                "Sender": {
                  "Expression": null
                },
                "Author": {
                  "Expression": null
                },
                "Recipients": {
                  "Expression": "{{Workflow.Properties[\"cUser\"].Email}}"
                },
                "Subject": {
                  "Expression": "TMS DN Post Result"
                },
                "Body": {
                  "Expression": "<style>...............\r\n  </div>\r\n  "
                },
                "IsBodyHtml": true,
                "BodyText": {
                  "Expression": "11111111111"
                },
                "IsBodyText": false,
                "Cc": {
                  "Expression": null
                },
                "ActivityMetadata": {
                  "Title": "TMS DN Post Result"
                },
                "IsHtmlBody": true
              }
            }

image

@hyzx86
Copy link
Contributor Author

hyzx86 commented May 25, 2023

@hishamco

The unit tests is using 'Body' Field

image

@agriffard agriffard changed the title EmailTask braking change EmailTask breaking change May 25, 2023
@sebastienros sebastienros added this to the 1.x milestone May 25, 2023
@sebastienros sebastienros modified the milestones: 1.x, 1.7 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants