Taxonomy Terms Management is broken

[urbanit]

Describe the bug

Terms in a Taxonomy cannot be deleted and hierarchy cannot be created

To Reproduce

Steps to reproduce the behavior:

1. Create a new site with Blog Recipe
2. Go To Category Taxonomy
3. Add a new term
4. Publish
5. Try to delete a term
6. A notification that term is deleted appears but term is still there

Expected behavior

Terms Management should include Term Deletion, Add Child Term, Move Term as Child

[urbanit]

It works on 1.8.2, broken on main branch

[Piedone]

Can you share the logs? I'd guess it has something to do with the Json.NET migration.

[urbanit]

For deleting term no logs are created :-(
For hierarchy, see attached...
orchard-log-2024-03-26.log

Full reproduction here: https://app.screencastify.com/v3/watch/g2Pv1BYQThXnZR3EoTsV

[MikeAlhayek]

Did you try it out using the latest commit on main? I think there was an issue with STJ where remove was broken but should be fixed. Can you please confirm that the issue exists even after pulling the latest from main?

[urbanit]

Exactly the same behavior... No deletion, no hierarchy, no child term addition

[MikeAlhayek]

Guessing this is where it fails

OrchardCore/src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs

Line 324 in 4d892b6

taxonomy.As<TaxonomyPart>().Content.Remove(taxonomyItemId);

[hishamco]

I think we need to fix the remove issue as we did in the admin menu

@hyzx86 @sarahelsaig I think you did a PR to fix this everywhere, right?

[hishamco]

@hyzx86 this PR #15509 should fix the issue, right? or Shall I did a similar fix to the admin menu

[hyzx86]

@hishamco , No，The PR #15509 just and some method ，
looking at the logs, it looks like the problem is with the JNode class,
PR #15524 was update the JNode class,
@sarahelsaig can you take a look ？

[hishamco]

Shall I do a similar fix to what I did in the admin menu?

[hyzx86]

Perhaps we can tweak the implementation of remove to be compatible with older api actions