You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The depends-on attribute available in script/tag helpers looks like it should work the same as declaring a dependency in a resource manifest, and cause the dependency to be included. This doesn't happen though, and the dependency is not included. The dependency order is only enforced when it was already included before.
In the manifest one uses ResourceDefinition.SetDependencies, and the tag helpers use RequireSettings.SetDependencies. Both are expanded in the same way in ResourceManager.ExpandDependenciesImplementation though, but still.
We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).
This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.
Describe the bug
Following up from #16531 (comment).
The
depends-on
attribute available in script/tag helpers looks like it should work the same as declaring a dependency in a resource manifest, and cause the dependency to be included. This doesn't happen though, and the dependency is not included. The dependency order is only enforced when it was already included before.In the manifest one uses
ResourceDefinition.SetDependencies
, and the tag helpers useRequireSettings.SetDependencies
. Both are expanded in the same way inResourceManager.ExpandDependenciesImplementation
though, but still.Orchard Core version
Latest
main
: 5c45566To Reproduce
AdminDashboard.cshtml
:jquery-resizable
is not.<script asp-name="jquery-resizable"></script>
a line above.jquery-resizable
is now included, correctly above the inline script.With 1.8.3 BTW the behavior is the same, so this is not a regression.
Expected behavior
jquery-resizable
is included also under step 2.Logs and screenshots
The text was updated successfully, but these errors were encountered: