Accessibility issue in notification widget

[sarahelsaig]

Describe the bug

I was running accessibility check on the site with several modules enabled. Everything is fine, except the notifications widget.

This could be related to the changes in #15231, though that's just a guess based on the file history of UserNotificationNavbar.cshtml.
The accessibility report is attached below.

Orchard Core version

Latest main.

To Reproduce

Steps to reproduce the behavior:

1. Set up the site.
2. Enable the Notifications feature.
3. Use axe to evaluate the home page.

Expected behavior

The dropdown element should have an appropriate title, aria-label or aria-labelledby attribute.

Logs

1: Links must have discernible text
Description: Ensures links have discernible text
Help: Links must have discernible text
Help URL: https://dequeuniversity.com/rules/axe/4.9/link-name?application=axe-core-selenium-nuget
Impact: serious
Tags: cat.name-role-value, wcag2a, wcag244, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.2.4.4, EN-9.4.1.2, ACT
Element(s):
Html:

Selector:

a[data-bs-auto-close="outside"]
To solve:

Fix all of the following issues:

SERIOUS: Element is in tab order and does not have accessible text

Fix at least one of the following issues:

SERIOUS: Element does not have text that is visible to screen readers
SERIOUS: aria-label attribute does not exist or is empty
SERIOUS: aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
SERIOUS: Element has no title attribute

[github-actions]

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

[DrewBrasher]

If no one is working on this issue I will work on it and create a PR

[MikeAlhayek]

@DrewBrasher please submit a PR

[DrewBrasher]

I tried adding an aria-label to the notification button but my change isn't showing up in the html when I run it. I'm thinking this is because the menus are cached. Do I need to disable menu caching and if so how do I do that?

[DrewBrasher]

Disregard that last question. Thanks to @MikeAlhayek's (#16875 (comment)), I see now that the TheTheme is overriding this view.