Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential display perf improvements #16676

Open
sebastienros opened this issue Sep 5, 2024 · 1 comment
Open

Potential display perf improvements #16676

sebastienros opened this issue Sep 5, 2024 · 1 comment

Comments

@sebastienros
Copy link
Member

While looking at display events I noticed some potential improvements

  • PlacementInfo and its results (tab/group/alternates) could be reused since they don't change when created from a string source
  • ShapeDescriptor uses collections that might be empty. Check if we can lazy-load them. Note that they should be already reused across tenants so maybe it's not much gain at least for the cost of instantiation, not memory usage which would still be gained.
  • Alternate collections like the ones for content parts in ContentPartDisplayDriver<TPart> should remain constant across usages. Maybe these could be cached per part. Or at least used as an immutable collection such that other parts of the code can be based on it. Another option is to have a list of collections so one can be reused while others can be added dynamically.
@Piedone Piedone added the perf label Sep 6, 2024
@Piedone Piedone changed the title Potential perf improvements Potential display perf improvements Sep 23, 2024
@sebastienros sebastienros added this to the 2.x milestone Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants