Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrchardCore.Translations.All is not referenced by OrchardCore.Application.Cms.Core.Targets #17035

Closed
Skrypt opened this issue Nov 18, 2024 · 2 comments · Fixed by #17036
Closed
Milestone

Comments

@Skrypt
Copy link
Contributor

Skrypt commented Nov 18, 2024

If someone wants to use a module it should be properly translated at all time.
I suggest we move the reference to OrchardCore.Application.Cms.Core instead.

Unless what we expected was translations would not be supported when using OrchardCore.Application.Cms.Core.Targets on a web project instead of the latter.

The goal for us is to not load all the themes that comes with Orchard while still being able to use DataAnnotations translations.

Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

1 similar comment
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants